This repository was archived by the owner on May 14, 2024. It is now read-only.
Update SocketIO.m #208
Open
Update SocketIO.m #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sendEvent assumes the incoming data isn't an NSArray already; this causes it to double-wrap NSArray objects (so instead of [data], you end up with [[data]]. Check if the incoming objet is of type NSArray, and if so pass it along verbatim.
|
It's possible I'm not understanding how this code works, but I have some server communication using socket-io that expects the args argument to be something like "[NSDictionary_, NSString_]" (which is likely bogus, but nonetheless, what I have to work with). If there's another way to do this, I'm all ears. |
|
I was having issues with multiple parameters like: Because of the double-wrap all data will go to first parameter. This pull request solves it, hope it merges! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendEvent assumes the incoming data isn't an NSArray already; this causes it to double-wrap NSArray objects (so instead of [data], you end up with [[data]]. Check if the incoming objet is of type NSArray, and if so pass it along verbatim.